messere1 commented on PR #6729:
URL:
https://github.com/apache/rocketmq-dashboard/pull/6729#issuecomment-6269120397
Both changes are in 9595e94b — thank you:
1. **Single-source runtime check** — the inline `vendor !== 'APACHE'` is
gone; the guard now reads `!supportsApacheRuntime({ vendor:
directConsumeCapability.vendor })`. The capability state stores the raw
`InstanceVendor | undefined` (the local `?? null` normalization is dropped), so
the undefined case flows through the helper's own undefined-means-Apache
convention instead of a second one.
2. **Comment reworded** — the 501 claim is gone from the `message.tsx`
comment and the test comment; both now state the actual constraint: cloud group
rows carry no online instances, so the footer selectors can never fill. The
description's 501 bullet is corrected the same way.
Verified on the amended head: `tsc -b` clean;
`MessagePageAsyncState.test.tsx` 24/24 — including
`disablesDirectConsumeWithReasonWhenCloudVendorsCannotEnumerateTargetsTest`,
which still drives a TENCENT instance through the disabled-with-reason path via
the helper — and `MessagePage.test.tsx` 29/29; eslint and Prettier clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
