yx9o opened a new pull request, #7282: URL: https://github.com/apache/rocketmq-dashboard/pull/7282
## What is the purpose of the change Instances configured for one physical Broker cluster can share NameServers with other clusters. Proxy discovery used an unaddressed heartbeat-syncer lookup, which could return another cluster's proxies instead of the configured cluster's inventory. ## Brief changelog - Resolve the configured cluster's Broker membership before discovering proxies. - Query the heartbeat-syncer group through explicit member Broker addresses, then merge and deduplicate proxy endpoints in stable order. - Return an empty inventory when the configured cluster is absent, and reject unavailable topology or membership instead of falling back to a global lookup. - Add regressions for shared NameServers, aggregation across multiple member Brokers, missing clusters, and unavailable membership. Instances without a configured Broker cluster retain the existing discovery behavior. Public response fields and default Proxy ports are unchanged. ## Verifying this change Using JDK 22 with the project's Java 21 compilation target: - `cd server && mvn -B -ntp -Dtest=RocketMQClusterProviderTest test` before the production fix: 37 tests, 6 expected regression failures, 0 errors; the existing 31 cases passed. - `cd server && mvn -B -ntp -Dtest=RocketMQClusterProviderTest,ProxyListToolHandlerTest,ProxyAddressServiceTest,InstanceResolverTest,RuntimeAdminClientResolverTest test` after the fix: 78 tests passed, 0 failures, 0 errors, 0 skipped. Compilation and Checkstyle passed in the same run. - `git diff --check` passed. These are unit tests with mocked admin responses. No live Broker/Proxy integration or full backend suite was run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
