coder999o opened a new pull request, #7291: URL: https://github.com/apache/rocketmq-dashboard/pull/7291
## What is the purpose of the change Fixes #7290. An empty account-level `whiteRemoteAddress` means no source restriction, but the ACL diagnostic classified it as scoped. An unrestricted administrator could therefore appear healthy with score 100, without the existing broad-account and broad-administrator findings. ## Brief changelog - Classify missing, null, empty and whitespace-only account address lists as open, reusing the existing findings and summary calculation. - Preserve empty global-whitelist semantics and all non-empty address classification. - Add five regressions and adapt a page assertion to account names appearing in both the account table and the newly-correct risk findings. This changes risk reporting only; API, storage and Broker authorization enforcement are unchanged. Existing unrestricted accounts may now receive critical findings. All-state review included #6443/#7092 (bounded wildcard classification), #7110 (`/0`), and #4969 (a separate proposed backend rule-source auditor API); none fixes this existing Plain Access account diagnostic. ## Verifying this change From `web/`: - Before the production fix: `npm test -- aclRiskDiagnostics --maxWorkers=1` failed all five new cases (`healthy` instead of `critical`); the eight existing cases passed. - `npm test -- aclRiskDiagnostics AclPage aclService.test.ts api/acl.test.ts --maxWorkers=1`: all 63 tests passed across four files. - `npx tsc -b --pretty false`: passed. - ESLint and `prettier --check` on all three changed files: passed. - `git diff --check`: passed; complete diff reviewed for scope and compatibility. Evidence is from source inspection and local utility/component/API tests with mocked services. No live browser or Broker verification is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
