X-LightYear opened a new pull request, #7293: URL: https://github.com/apache/rocketmq-dashboard/pull/7293
## Summary - reject relative or host-less `--server` values in `rmqctl config set-context` - prevent malformed context URLs from being persisted - add deterministic regression coverage for rejected context creation ## Root cause `set-context` parsed the server value only for URL parsing errors and credential/query/fragment checks. Relative values such as `studio.example.com` were therefore written to the context file, although the request client later rejected them as invalid Studio Server URLs. ## Fix Require a non-empty URL scheme and hostname before saving a changed `--server` value. ## Testing - pre-fix regression failed because the command accepted `studio.example.com` - `go test ./rmqctl/cmd -run TestConfigSetContextRejectsRelativeServerURLBeforeSaving -count=1` - related config tests passed - `go test ./rmqctl/cmd`: passed - `go test ./...`: package tests passed; existing Windows/WSL build-script and binary-license packaging tests remain environment/tooling failures Fixes #7292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
