Add RocketMQConnectionFactoryTest
Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/commit/84775eba Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/tree/84775eba Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/diff/84775eba Branch: refs/heads/jms-dev-1.1.0 Commit: 84775eba0715bf643476cdbe02c1a6f3f6188ea2 Parents: 33a9a31 Author: zhangke <[email protected]> Authored: Tue Feb 28 19:38:26 2017 +0800 Committer: zhangke <[email protected]> Committed: Tue Feb 28 19:40:59 2017 +0800 ---------------------------------------------------------------------- .../apache/rocketmq/jms/RocketMQConnection.java | 2 +- .../jms/msg/serialize/ObjectSerialize.java | 2 +- .../jms/RocketMQConnectionFactoryTest.java | 36 ++++++++++++++++++++ 3 files changed, 38 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/84775eba/core/src/main/java/org/apache/rocketmq/jms/RocketMQConnection.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/rocketmq/jms/RocketMQConnection.java b/core/src/main/java/org/apache/rocketmq/jms/RocketMQConnection.java index 282c86e..db6d897 100644 --- a/core/src/main/java/org/apache/rocketmq/jms/RocketMQConnection.java +++ b/core/src/main/java/org/apache/rocketmq/jms/RocketMQConnection.java @@ -58,7 +58,7 @@ public class RocketMQConnection implements Connection { private List<RocketMQSession> sessionList = new ArrayList(); private AtomicBoolean started = new AtomicBoolean(false); - protected RocketMQConnection(String nameServerAddress, String clientID, String instanceName, String userName, + public RocketMQConnection(String nameServerAddress, String clientID, String instanceName, String userName, String password) { this.clientID = clientID; this.userName = userName; http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/84775eba/core/src/main/java/org/apache/rocketmq/jms/msg/serialize/ObjectSerialize.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/rocketmq/jms/msg/serialize/ObjectSerialize.java b/core/src/main/java/org/apache/rocketmq/jms/msg/serialize/ObjectSerialize.java index efa270c..5e72955 100644 --- a/core/src/main/java/org/apache/rocketmq/jms/msg/serialize/ObjectSerialize.java +++ b/core/src/main/java/org/apache/rocketmq/jms/msg/serialize/ObjectSerialize.java @@ -57,7 +57,7 @@ public class ObjectSerialize implements Serialize<Object> { ObjectInputStream ois = new ObjectInputStream(bais); ois.close(); bais.close(); - return (Serializable)ois.readObject(); + return (Serializable) ois.readObject(); } catch (IOException e) { throw new JMSException(e.getMessage()); http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/84775eba/core/src/test/java/org/apache/rocketmq/jms/RocketMQConnectionFactoryTest.java ---------------------------------------------------------------------- diff --git a/core/src/test/java/org/apache/rocketmq/jms/RocketMQConnectionFactoryTest.java b/core/src/test/java/org/apache/rocketmq/jms/RocketMQConnectionFactoryTest.java new file mode 100644 index 0000000..61f1e54 --- /dev/null +++ b/core/src/test/java/org/apache/rocketmq/jms/RocketMQConnectionFactoryTest.java @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.rocketmq.jms; + +import org.junit.Test; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.core.Is.is; +import static org.hamcrest.core.IsNull.notNullValue; + +public class RocketMQConnectionFactoryTest { + + @Test + public void testClientId() throws Exception { + final String nameServerAddress = "localhost:6789"; + RocketMQConnectionFactory connectionFactory = new RocketMQConnectionFactory(nameServerAddress); + + assertThat(connectionFactory.getNameServerAddress(), is(nameServerAddress)); + assertThat(connectionFactory.getClientId(), notNullValue()); + } +} \ No newline at end of file
