Perfect pom to support jar/source/javadoc

Project: 
http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/commit/189cff81
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/tree/189cff81
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/diff/189cff81

Branch: refs/heads/jms-dev-1.1.0
Commit: 189cff81ee13880b60fbd7eea612e26e815108ae
Parents: 544eda2
Author: zhangke <[email protected]>
Authored: Fri Mar 3 07:14:14 2017 +0800
Committer: zhangke <[email protected]>
Committed: Fri Mar 3 07:14:14 2017 +0800

----------------------------------------------------------------------
 pom.xml                                         | 30 ++++++++++++++++++--
 .../rocketmq/jms/RocketMQConnectionFactory.java |  2 +-
 .../rocketmq/jms/msg/JMSBytesMessage.java       |  2 +-
 style/checkstyle-suppressions.xml               | 10 +++++++
 4 files changed, 40 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/189cff81/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 2811413..51a4ab5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,10 +29,8 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <!--maven properties -->
         <maven.test.skip>false</maven.test.skip>
         <maven.javadoc.skip>true</maven.javadoc.skip>
-        <!-- compiler settings properties -->
         <maven.compiler.source>1.7</maven.compiler.source>
         <maven.compiler.target>1.7</maven.compiler.target>
         <surefire.version>2.19.1</surefire.version>
@@ -40,6 +38,14 @@
         <spring.version>4.3.6.RELEASE</spring.version>
     </properties>
 
+    <licenses>
+        <license>
+            <name>Apache License, Version 2.0</name>
+            <url>http://www.apache.org/licenses/LICENSE-2.0</url>
+            <distribution>repo</distribution>
+        </license>
+    </licenses>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.rocketmq</groupId>
@@ -124,6 +130,17 @@
     </dependencies>
 
     <build>
+        <finalName>rocketmq-jms-${project.version}</finalName>
+        <!--<resources>-->
+            <!--<resource>-->
+                <!--<directory>${project.basedir}</directory>-->
+                <!--<targetPath>META-INF</targetPath>-->
+                <!--<includes>-->
+                    <!--<include>LICENSE</include>-->
+                    <!--<include>NOTICE</include>-->
+                <!--</includes>-->
+            <!--</resource>-->
+        <!--</resources>-->
         <plugins>
             <plugin>
                 <artifactId>maven-compiler-plugin</artifactId>
@@ -168,6 +185,15 @@
                 </executions>
             </plugin>
             <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <configuration>
+                    <excludes>
+                        <exclude>**/logback.xml</exclude>
+                    </excludes>
+                </configuration>
+            </plugin>
+            <plugin>
                 <artifactId>maven-source-plugin</artifactId>
                 <version>3.0.1</version>
                 <executions>

http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/189cff81/src/main/java/org/apache/rocketmq/jms/RocketMQConnectionFactory.java
----------------------------------------------------------------------
diff --git 
a/src/main/java/org/apache/rocketmq/jms/RocketMQConnectionFactory.java 
b/src/main/java/org/apache/rocketmq/jms/RocketMQConnectionFactory.java
index c81e8b5..16ce1e0 100644
--- a/src/main/java/org/apache/rocketmq/jms/RocketMQConnectionFactory.java
+++ b/src/main/java/org/apache/rocketmq/jms/RocketMQConnectionFactory.java
@@ -71,7 +71,7 @@ public class RocketMQConnectionFactory implements 
ConnectionFactory {
      * @param userName ignored
      * @param password ignored
      * @return the new JMS Connection
-     * @throws JMSException
+     * @throws JMSException if create connection fail
      */
     @Override
     public Connection createConnection(String userName, String password) 
throws JMSException {

http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/189cff81/src/main/java/org/apache/rocketmq/jms/msg/JMSBytesMessage.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/rocketmq/jms/msg/JMSBytesMessage.java 
b/src/main/java/org/apache/rocketmq/jms/msg/JMSBytesMessage.java
index a409118..4bdf58b 100644
--- a/src/main/java/org/apache/rocketmq/jms/msg/JMSBytesMessage.java
+++ b/src/main/java/org/apache/rocketmq/jms/msg/JMSBytesMessage.java
@@ -50,7 +50,7 @@ public class JMSBytesMessage extends AbstractJMSMessage 
implements javax.jms.Byt
     /**
      * Message created for reading
      *
-     * @param data
+     * @param data to construct this object
      */
     public JMSBytesMessage(byte[] data) {
         this.bytesIn = data;

http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-externals/blob/189cff81/style/checkstyle-suppressions.xml
----------------------------------------------------------------------
diff --git a/style/checkstyle-suppressions.xml 
b/style/checkstyle-suppressions.xml
new file mode 100644
index 0000000..0174c40
--- /dev/null
+++ b/style/checkstyle-suppressions.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.0//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd";>
+
+<suppressions>
+    <suppress files="LICENSE"/>
+    <suppress files="NOTICE"/>
+</suppressions>
\ No newline at end of file

Reply via email to