[
https://issues.apache.org/roller/browse/ROL-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14416#action_14416
]
Ganesh Mathrubootham commented on ROL-1750:
-------------------------------------------
And, I have tested this patch in my local machine. Sources compile fine and
the functionality looks good too.
> PlanetURLStrategy needs to be moved out of ui package
> -------------------------------------------------------
>
> Key: ROL-1750
> URL: https://issues.apache.org/roller/browse/ROL-1750
> Project: Roller
> Issue Type: Improvement
> Components: Build Process
> Reporter: Ganesh Mathrubootham
> Assignee: Roller Unassigned
> Priority: Trivial
> Attachments: move_PlanetURLStrategy.patch
>
>
> The location of PlanetURLStrategy.java is preventing a clear separation
> between web tier and business tier.
> This class is currently packaged under org.apache.roller.weblogger.planet.ui.
> Like all other Strategy classes, this belongs to business layer and so
> should probably go under org.apache.roller.weblogger.planet.business
> I discovered this issue when I tried to create separate projects for web and
> business layers in my Eclipse IDE. I followed the inclusion and exclusion
> patterns defined in the ant script, removed roller-business.jar and
> roller-web.jar from classpath to avoid duplication and made my web project
> dependent on business project. At this point, I am getting compilation error
> in org/apache/roller/weblogger/planet/business/jpa/RollerPlanetModule.java
> (business project) as it is referring to PlanetURLStrategy.java, which is in
> web project because of the way inclusion/exclusion patterns are defined.
> This problem can be easily resolved by moving PlanetURLStrategy.java from
> org.apache.roller.weblogger.planet.ui to
> org.apache.roller.weblogger.planet.business
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
