[
https://issues.apache.org/jira/browse/ROL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Glen Mazza closed ROL-1203.
---------------------------
Resolution: Cannot Reproduce
Unsure what is meant by popup comments -- I don't think we have today. Two of
the three classes mentioned no longer exist.
> Popup comment pages cached the same as permalink pages
> ------------------------------------------------------
>
> Key: ROL-1203
> URL: https://issues.apache.org/jira/browse/ROL-1203
> Project: Apache Roller
> Issue Type: Bug
> Components: Comments
> Affects Versions: 2.3
> Reporter: Richard Jones
> Assignee: Roller Unassigned
>
> classes effected:
> org.apache.roller.presentation.WeblogPageRequest.java
> org.apache.roller.presentation.filters.WeblogPageCacheFilter.java
> org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.java
> The page caching does not take into account the '&popup=true' parameter.
> This means the following pages will be cached as the same
> /roller/page/handle?entry=new_entry_1
> and
> /roller/page/handle?entry=new_entry_1&popup=true
> This causes roller to return the permalink pages when the popup comments form
> was requested and viceversa.
> Resolution:
> Add 'private string weblogPopup' to WeblogPageRequest.java and change the
> 'generateKey()' methods in WeblogPageCacheFilter.java and
> IfModifiedWeblogPageCacheFilter.java to check for the popup parameter (I can
> provide the code if requested).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
