[ 
https://issues.apache.org/jira/browse/ROL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862016#comment-16862016
 ] 

Aditya Sharma commented on ROL-2138:
------------------------------------

Thanks [~sebb] for the review :)
{quote}The NOTICE file includes the line:

"This product includes software developed by"

I'm not sure where you got that from, but it is incorrect.
{quote}
The lines are there in sublinks see 
[here|https://www.apache.org/legal/src-headers.html#notice]

I went through some other sub links and as per 
[this|https://www.apache.org/dev/licensing-howto.html#mod-notice] link

??Copyright notifications which have been 
[relocated|http://www.apache.org/legal/src-headers.html#headers] from source 
files (rather than removed) must be preserved in {{NOTICE}}. However, elements 
such as the copyright notifications embedded within BSD and MIT licenses need 
not be duplicated in {{NOTICE}} -- it suffices to leave those notices in their 
original locations.??

So I kept all the copyright notices as it is. 
Though I will go through the content again, please correct me if I missed on 
something.

Thanks!

 

> NOTICE file does not have standard content
> ------------------------------------------
>
>                 Key: ROL-2138
>                 URL: https://issues.apache.org/jira/browse/ROL-2138
>             Project: Apache Roller
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Aditya Sharma
>            Priority: Critical
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The NOTICE file in the 5.2.2 release does not have the standard format [1] 
> for a NOTICE file
> It does not have the standard header.
> It also contains material which should not be present.
> Note that the NOTICE and LICENSE files must only include details of software 
> which is actually included in the bundle to which they relate. In this case, 
> the binary bundle contains 3rd party (and other ASF) software, so the NOTICE 
> and LICENSE files should be different.
> Furthermore, the text of all relevant licenses must be included in the 
> bundle; links to external licenses are not sufficient. The license text can 
> either be appended to the LICENSE file, or included in separate files linked 
> from the LICENSE file.
> [1] 
> http://www.apache.org/dev/licensing-howto.html#assembling-license-and-notice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to