[
https://issues.apache.org/jira/browse/ROL-2159?focusedWorklogId=344129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344129
]
ASF GitHub Bot logged work on ROL-2159:
---------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 10:28
Start Date: 15/Nov/19 10:28
Worklog Time Spent: 10m
Work Description: adityasharma7 commented on pull request #49: Added
'@Override' should be used on overriding and implementing methods. (ROL-2159)
URL: https://github.com/apache/roller/pull/49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344129)
Time Spent: 20m (was: 10m)
> "@Override" should be used on overriding and implementing methods
> -----------------------------------------------------------------
>
> Key: ROL-2159
> URL: https://issues.apache.org/jira/browse/ROL-2159
> Project: Apache Roller
> Issue Type: Improvement
> Affects Versions: 6.0.0
> Reporter: Saurabh Dixit
> Assignee: Saurabh Dixit
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Using the {{@Override}} annotation is useful for two reasons :
> * It elicits a warning from the compiler if the annotated method doesn't
> actually override anything, as in the case of a misspelling.
> * It improves the readability of the source code by making it obvious that
> methods are overridden.
> h2. Noncompliant Code Example
> {code:java}
> class ParentClass {
> public boolean doSomething(){...}
> }
> class FirstChildClass extends ParentClass {
> public boolean doSomething(){...} // Noncompliant
> }{code}
> h2. Compliant Solution
> {code:java}
> class ParentClass {
> public boolean doSomething(){...}
> }
> class FirstChildClass extends ParentClass {
> @Override
> public boolean doSomething(){...} // Compliant
> }{code}
> h2. Exceptions
> This rule is relaxed when overriding a method from the {{Object}} class like
> {{toString()}}, {{hashCode()}}, ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
