This is an automated email from the ASF dual-hosted git repository.

mbien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/roller.git

commit 27c120127a453413a581a2d0991b8963255c376e
Author: Michael Bien <[email protected]>
AuthorDate: Wed Aug 25 01:01:29 2021 +0200

    close the right stream (getter would return a new stream).
---
 .../apache/roller/weblogger/business/themes/ThemeManagerImpl.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/app/src/main/java/org/apache/roller/weblogger/business/themes/ThemeManagerImpl.java
 
b/app/src/main/java/org/apache/roller/weblogger/business/themes/ThemeManagerImpl.java
index 8603263..1346717 100644
--- 
a/app/src/main/java/org/apache/roller/weblogger/business/themes/ThemeManagerImpl.java
+++ 
b/app/src/main/java/org/apache/roller/weblogger/business/themes/ThemeManagerImpl.java
@@ -65,7 +65,7 @@ import org.apache.roller.weblogger.util.RollerMessages;
 @com.google.inject.Singleton
 public class ThemeManagerImpl implements ThemeManager {
 
-       static FileTypeMap map = null;
+       private static final FileTypeMap map;
        static {
                // TODO: figure out why PNG is missing from Java MIME types
                map = FileTypeMap.getDefaultFileTypeMap();
@@ -77,7 +77,7 @@ public class ThemeManagerImpl implements ThemeManager {
                }
        }
 
-       private static Log log = LogFactory.getLog(ThemeManagerImpl.class);
+       private static final Log log = 
LogFactory.getLog(ThemeManagerImpl.class);
        private final Weblogger roller;
        // directory where themes are kept
        private String themeDir = null;
@@ -354,7 +354,7 @@ public class ThemeManagerImpl implements ThemeManager {
                                RollerMessages errors = new RollerMessages();
                                fileMgr.createThemeMediaFile(weblog, mf, 
errors);
                                try {
-                                       resource.getInputStream().close();
+                                       is.close();
                                } catch (IOException ex) {
                                        errors.addError("error.closingStream");
                                        log.debug("ERROR closing inputstream");

Reply via email to