[royale-asjs] branch develop updated: Drawer open() and close() methods, and make Drawer close when select and option on JewelExample

[carlosrovira]

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 73d135b  Drawer open() and close() methods, and make Drawer close when 
select and option on JewelExample
73d135b is described below

commit 73d135be35ad2d5645f6b93e2f077fd01c6ab27c
Author: Carlos Rovira <carlosrov...@apache.org>
AuthorDate: Tue Jul 3 10:34:33 2018 +0200

    Drawer open() and close() methods, and make Drawer close when select and 
option on JewelExample
---
 .../JewelExample/src/main/royale/MainContent.mxml  |  3 ++-
 .../main/royale/org/apache/royale/jewel/Drawer.as  | 28 +++++++++++++++-------
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/examples/royale/JewelExample/src/main/royale/MainContent.mxml 
b/examples/royale/JewelExample/src/main/royale/MainContent.mxml
index 2aeb7e9..c069751 100644
--- a/examples/royale/JewelExample/src/main/royale/MainContent.mxml
+++ b/examples/royale/JewelExample/src/main/royale/MainContent.mxml
@@ -35,6 +35,7 @@ limitations under the License.
 
                            var link:String = renderer.href;
                 main.showContent(link);
+                drawer.close();
             }
         ]]>
     </fx:Script>
@@ -75,7 +76,7 @@ limitations under the License.
     <j:TopAppBar id="topappbar" fixed="true">
         <j:TopAppBarRow>
             <j:TopAppBarSection>
-                <j:Button click="drawer.open = !drawer.open">
+                <j:Button click="drawer.open()">
                     <j:icon>
                         <js:Icon text="{MaterialIconType.MENU}" 
material="true"/>
                     </j:icon>
diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
index 4dcff90..c38b7a8 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/Drawer.as
@@ -72,13 +72,13 @@ package org.apache.royale.jewel
                                var hostClassList:DOMTokenList = 
hostComponent.positioner.classList;
                                if (hostClassList.contains("drawer"))
                                {
-                                       open = false;
+                                       close();
                                        //dispatchEvent(new 
Event("closeDrawer"));
                                }
                        }
                }
 
-               private var _open:Boolean;
+               private var _isOpen:Boolean;
         /**
          *  Open or close the drawer
          *
@@ -87,26 +87,36 @@ package org.apache.royale.jewel
          *  @playerversion AIR 2.6
          *  @productversion Royale 0.9.3
          */
-               public function get open():Boolean
+               public function get isOpen():Boolean
                {
-            return _open;
+            return _isOpen;
                }
 
-               public function set open(value:Boolean):void
+               public function set isOpen(value:Boolean):void
                {
-            if (_open != value)
+            if (_isOpen != value)
             {
-                _open = value;
+                _isOpen = value;
 
-                toggleClass("open", _open);
+                toggleClass("open", _isOpen);
 
                                COMPILE::JS
                                {//avoid scroll in html
-                                       
document.body.classList.toggle("remove-app-scroll", _open);
+                                       
document.body.classList.toggle("remove-app-scroll", _isOpen);
                                }
             }
                }
 
+               public function open():void
+               {
+            isOpen = true;
+               }
+
+               public function close():void
+               {
+            isOpen = false;
+               }
+
                COMPILE::JS
                private var nav:HTMLElement;