This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit b12e34255ffa90869abe45adafda826746cce068
Author: Alex Harui <aha...@apache.org>
AuthorDate: Thu Jan 10 22:45:56 2019 -0800
clean up warnings from Closure
---
.../src/main/royale/mx/controls/ToggleButtonBar.as | 2 +-
.../controls/treeClasses/HierarchicalCollectionView.as | 2 +-
.../MXRoyale/src/main/royale/mx/messaging/Channel.as | 2 +-
.../mx/messaging/channels/NetConnectionChannel.as | 6 ++++--
.../main/royale/mx/messaging/config/ServerConfig.as | 8 ++------
.../src/main/royale/mx/rpc/http/AbstractOperation.as | 18 +++++++++---------
.../MXRoyale/src/main/royale/mx/utils/ObjectUtil.as | 11 ++++-------
7 files changed, 22 insertions(+), 27 deletions(-)
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/ToggleButtonBar.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/ToggleButtonBar.as
index a93a740..a64e0a9 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/ToggleButtonBar.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/ToggleButtonBar.as
@@ -223,7 +223,7 @@ public class ToggleButtonBar extends UIComponent implements
ILayoutParent, ILayo
public function ToggleButtonBar()
{
super();
- widthType == ButtonBarModel.NATURAL_WIDTHS;
+ widthType = ButtonBarModel.NATURAL_WIDTHS;
}
/**
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/treeClasses/HierarchicalCollectionView.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/treeClasses/HierarchicalCollectionView.as
index 6ed7cf9..b1aaa91 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/treeClasses/HierarchicalCollectionView.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/treeClasses/HierarchicalCollectionView.as
@@ -931,7 +931,7 @@ public class HierarchicalCollectionView extends
EventDispatcher
{
var p:*;
- children == null;
+ children = null;
// lookup doesn't work, must scan
instead
COMPILE::SWF
{
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/Channel.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/Channel.as
index 76f4ddd..e99ad32 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/Channel.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/Channel.as
@@ -1467,7 +1467,7 @@ public class Channel extends EventDispatcher implements
IMXMLObject
{
// Apply exponential backoff.
var delay:int = 1000; // 1 second.
- delay << ++_reliableReconnectAttempts;
+ delay = delay << ++_reliableReconnectAttempts;
if (delay < remaining)
{
new AsyncDispatcher(reconnect, null, delay);
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/channels/NetConnectionChannel.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/channels/NetConnectionChannel.as
index a9d9ffa..6cd6904 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/channels/NetConnectionChannel.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/channels/NetConnectionChannel.as
@@ -572,6 +572,8 @@ class NetConnectionMessageResponder extends MessageResponder
{
if (handled)
return;
+
+ var errorMsg:ErrorMessage;
disconnect();
if (msg is AsyncMessage)
@@ -596,7 +598,6 @@ class NetConnectionMessageResponder extends MessageResponder
}
else
{
- var errorMsg:ErrorMessage;
errorMsg = new ErrorMessage();
errorMsg.faultCode = "Server.Acknowledge.Failed";
errorMsg.faultString = resourceManager.getString(
@@ -621,6 +622,8 @@ class NetConnectionMessageResponder extends MessageResponder
{
if (handled)
return;
+
+ var errorMsg:ErrorMessage;
disconnect();
@@ -644,7 +647,6 @@ class NetConnectionMessageResponder extends MessageResponder
}
else
{
- var errorMsg:ErrorMessage;
errorMsg = new ErrorMessage();
errorMsg.faultCode = "Server.Acknowledge.Failed";
errorMsg.faultString = resourceManager.getString(
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/config/ServerConfig.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/config/ServerConfig.as
index 4774254..2f60e3c 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/config/ServerConfig.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/messaging/config/ServerConfig.as
@@ -328,18 +328,14 @@ public class ServerConfig
{
var destination:XMLList = xml..destination.(@id == destinationId);
- if (destination.length() > 0)
- {
- return destination.properties;
- }
- else
+ if (destination.length() == 0)
{
var message:String = resourceManager.getString(
"messaging", "unknownDestination", [ destinationId ]);
throw new InvalidDestinationError(message);
}
- return destination;
+ return destination.properties;
}
//--------------------------------------------------------------------------
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/http/AbstractOperation.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/http/AbstractOperation.as
index 0ae4b1b..044694e 100644
---
a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/http/AbstractOperation.as
+++
b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/http/AbstractOperation.as
@@ -810,10 +810,10 @@ package mx.rpc.http
*/
override public function cancel(id:String = null):AsyncToken
{
- if (showBusyCursor)
- {
+ //if (showBusyCursor)
+ //{
// CursorManager.removeBusyCursor();
- }
+ //}
return super.cancel(id);
}
@@ -1145,10 +1145,10 @@ package mx.rpc.http
override mx_internal function invoke(message:IMessage,
token:AsyncToken = null):AsyncToken
{
- if (showBusyCursor)
- {
+ //if (showBusyCursor)
+ //{
// CursorManager.setBusyCursor();
- }
+ //}
return super.invoke(message, token);
}
@@ -1158,10 +1158,10 @@ package mx.rpc.http
*/
override mx_internal function
preHandle(event:MessageEvent):AsyncToken
{
- if (showBusyCursor)
- {
+ //if (showBusyCursor)
+ //{
// CursorManager.removeBusyCursor();
- }
+ //}
var wasLastCall:Boolean =
activeCalls.wasLastCall(AsyncMessage(event.message).correlationId);
var token:AsyncToken = super.preHandle(event);
diff --git
a/frameworks/projects/MXRoyale/src/main/royale/mx/utils/ObjectUtil.as
b/frameworks/projects/MXRoyale/src/main/royale/mx/utils/ObjectUtil.as
index 39ea4bd..f2ac716 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/utils/ObjectUtil.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/utils/ObjectUtil.as
@@ -754,7 +754,7 @@ public class ObjectUtil
{
var n:int;
var i:int;
-
+ var p:String;
//if (obj is ObjectProxy)
// obj = ObjectProxy(obj).object_proxy::object;
@@ -836,7 +836,7 @@ public class ObjectUtil
}
else*/ if (isDynamic)
{
- for (var p:String in obj)
+ for (p in obj)
{
if (excludeObject[p] != 1)
{
@@ -976,7 +976,7 @@ public class ObjectUtil
{
var n:int;
var i:int;
-
+ var p:String;
//if (obj is ObjectProxy)
// obj = ObjectProxy(obj).object_proxy::object;
@@ -991,7 +991,6 @@ public class ObjectUtil
var classAlias:String;
var isDynamic:Boolean = false;
var metadataInfo:Object;
-
var excludeObject:Object = {};
if (excludes)
{
@@ -1075,12 +1074,10 @@ public class ObjectUtil
result["properties"] = propertyNames;
result["dynamic"] = isDynamic;
// result["metadata"] = metadataInfo = recordMetadata(properties);
-
-
var isArray:Boolean = (obj is Array);
if (isDynamic)
{
- for (var p:String in obj)
+ for (p in obj)
{
if (excludeObject[p] != 1)
{
