This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch feature/dataprovider-extensiblity
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to 
refs/heads/feature/dataprovider-extensiblity by this push:
     new d2d35df  move creation code to createAllItemRenderers
d2d35df is described below

commit d2d35df12d27b20864a379bf0c5c60a61b07ce8b
Author: Carlos Rovira <[email protected]>
AuthorDate: Thu Jul 23 21:54:40 2020 +0200

    move creation code to createAllItemRenderers
---
 .../TableItemRendererFactoryForCollectionView.as   | 25 +++++++++++++++-------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
index 2845765..efa3510 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/TableItemRendererFactoryForCollectionView.as
@@ -20,13 +20,11 @@ package org.apache.royale.jewel.beads.itemRenderers
 {
     import org.apache.royale.core.IChild;
     import org.apache.royale.core.IDataProviderItemRendererMapper;
-    import org.apache.royale.core.IIndexedItemRenderer;
     import org.apache.royale.core.IIndexedItemRendererInitializer;
-    import org.apache.royale.core.ILabelFieldItemRenderer;
+    import org.apache.royale.core.IItemRendererOwnerView;
     import org.apache.royale.core.IParent;
     import org.apache.royale.core.UIBase;
     import org.apache.royale.events.Event;
-    import org.apache.royale.events.IEventDispatcher;
     import org.apache.royale.html.beads.DataItemRendererFactoryBase;
     import org.apache.royale.html.beads.IListView;
     import org.apache.royale.html.supportClasses.StyledDataItemRenderer;
@@ -110,6 +108,20 @@ package org.apache.royale.jewel.beads.itemRenderers
             createHeader();
                        
                        // -- 2) CREATION PHASE
+                       createAllItemRenderers(tbody);
+                       
+                       dispatchItemCreatedEvent();
+            // table.dispatchEvent(new Event("layoutNeeded"));
+        }
+
+               /**
+                *  create all item renderers
+                *  
+                *  @royaleignorecoercion 
org.apache.royale.core.IIndexedItemRenderer
+                *  @royaleignorecoercion 
org.apache.royale.core.IIndexedItemRendererInitializer
+                */
+               override protected function 
createAllItemRenderers(dataGroup:IItemRendererOwnerView):void
+               {
                        var presentationModel:IListPresentationModel = 
_strand.getBeadByType(IListPresentationModel) as IListPresentationModel;
                        labelField = model.labelField;
                        
@@ -141,7 +153,7 @@ package org.apache.royale.jewel.beads.itemRenderers
                                        
                                        (itemRendererInitializer as 
IIndexedItemRendererInitializer).initializeIndexedItemRenderer(ir, data, index);
                     
-                                       tbody.addItemRendererAt(ir, index);
+                                       dataGroup.addItemRendererAt(ir, index);
                                        ir.labelField = labelField;
                                        
                                        if (presentationModel) {
@@ -159,10 +171,7 @@ package org.apache.royale.jewel.beads.itemRenderers
                                        index++;
                 }
                        }
-                       
-                       IEventDispatcher(_strand).dispatchEvent(new 
Event("itemsCreated"));
-            table.dispatchEvent(new Event("layoutNeeded"));
-        }
+               }
 
                public function removeElements(container: IParent):void
                {

Reply via email to