This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 43f2d8e  Fix memory leak due to grid item renderer leak on 
dataProviderChange events.
     new 750b8a3  Merge pull request #1029 from estanglerbm/adg-memory-leak
43f2d8e is described below

commit 43f2d8ede12adbf5849c88dd408be199bab16792
Author: Edward Stangler <[email protected]>
AuthorDate: Sun Jan 3 05:49:33 2021 -0600

    Fix memory leak due to grid item renderer leak on dataProviderChange events.
---
 .../beads/AdvancedDataGridListVirtualListView.as      | 19 +++++++++++++++++++
 ...erFactoryForICollectionViewAdvancedDataGridData.as |  5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git 
a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/beads/AdvancedDataGridListVirtualListView.as
 
b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/beads/AdvancedDataGridListVirtualListView.as
index 047b033..cca0fac 100644
--- 
a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/beads/AdvancedDataGridListVirtualListView.as
+++ 
b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/beads/AdvancedDataGridListVirtualListView.as
@@ -25,7 +25,9 @@ COMPILE::SWF
 {
     import org.apache.royale.core.IStrand;
 }
+import org.apache.royale.core.IChild;
 import org.apache.royale.core.IItemRenderer;
+import org.apache.royale.core.IParent;
 import org.apache.royale.core.IRollOverModel;
 import org.apache.royale.core.ISelectableItemRenderer;
 import org.apache.royale.core.ISelectionModel;
@@ -107,6 +109,23 @@ public class AdvancedDataGridListVirtualListView extends 
VirtualListView
         }
     }
 
+    /**
+     * @copy 
org.apache.royale.core.IItemRendererOwnerView#removeAllItemRenderers()
+     * @private
+     *
+     *  @langversion 3.0
+     *  @playerversion Flash 10.2
+     *  @playerversion AIR 2.6
+     *  @productversion Royale 0.9.8
+     *  @royaleignorecoercion org.apache.royale.core.IParent
+     */
+    override public function removeAllItemRenderers():void
+    {
+        while ((contentView as IParent).numElements > 0) {
+            var child:IChild = (contentView as IParent).getElementAt(0);
+            (contentView as IParent).removeElement(child);
+        }
+    }
 }
 }
 
diff --git 
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
 
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
index 2d5d587..0a09356 100644
--- 
a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
+++ 
b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/advancedDataGridClasses/DataItemRendererFactoryForICollectionViewAdvancedDataGridData.as
@@ -107,8 +107,9 @@ package mx.controls.advancedDataGridClasses
             //dped.addEventListener(CollectionEvent.ITEM_REMOVED, 
itemRemovedHandler);
             //dped.addEventListener(CollectionEvent.ITEM_UPDATED, 
itemUpdatedHandler);
             
-            //dataGroup.removeAllItemRenderers();
-                        
+            var view:IListView = (_strand as IStrandWithModelView).view as 
IListView;
+            var dataGroup:IItemRendererOwnerView = view.dataGroup;
+            dataGroup.removeAllItemRenderers();                        
             rendererMap = {};
             IEventDispatcher(_strand).dispatchEvent(new Event("itemsCreated"));
             IEventDispatcher(_strand).dispatchEvent(new Event("layoutNeeded"));

Reply via email to