This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git

commit 431483acbe614d0eb236624dd56f966a6fbc9146
Author: Josh Tynjala <[email protected]>
AuthorDate: Wed Mar 5 16:02:05 2025 -0800

    UnaryOperatorEmitter: add comment about hacky use of string LiteralNode 
without quotes for member access
---
 .../royale/compiler/internal/codegen/js/jx/UnaryOperatorEmitter.java   | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/UnaryOperatorEmitter.java
 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/UnaryOperatorEmitter.java
index c8988b70d..2bc5a79a1 100644
--- 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/UnaryOperatorEmitter.java
+++ 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/UnaryOperatorEmitter.java
@@ -70,6 +70,9 @@ public class UnaryOperatorEmitter extends JSSubEmitter 
implements
             String synthTagName = 
fjs.formatQualifiedName(JSRoyaleEmitterTokens.LANGUAGE_QNAME.getToken())
                     + ASEmitterTokens.MEMBER_ACCESS.getToken()
                     + 
JSRoyaleEmitterTokens.ROYALE_SYNTH_TAG_FIELD_NAME.getToken();
+            // this is hacky. we want to emit member access, but we're creating
+            // a string literal without quotes. we should create the 
appropriate
+            // member access node instead. -JT
             LiteralNode synthType = new 
LiteralNode(ILiteralNode.LiteralType.STRING, synthTagName);
             synthType.setSynthetic(true);
             DynamicAccessNode patchedVectorReference = new 
DynamicAccessNode(((ExpressionNodeBase)((MemberAccessExpressionNode) 
node.getOperandNode()).getLeftOperandNode()));

Reply via email to