This is an automated email from the ASF dual-hosted git repository. joshtynjala pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit 4dc4c0f3c020aa8bbb064d36f2c3aed420e75a1a Author: Josh Tynjala <[email protected]> AuthorDate: Mon Mar 9 08:10:35 2026 -0700 JSConfiguration: move warn-this-within-closure default value of true from Configuration Configuration tries to keep closer to defaults of Flex SDK, since it may be used with other frameworks. This warning can be a good default for Royale apps, especially in JS. That's where arrow functions are enabled by default, which is the better option. --- .../src/main/java/org/apache/royale/compiler/config/Configuration.java | 2 +- .../main/java/org/apache/royale/compiler/clients/JSConfiguration.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java b/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java index 04512f3a0..eb4228c3a 100644 --- a/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java +++ b/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java @@ -4187,7 +4187,7 @@ public class Configuration // 'compiler.warn-this-within-closure' option // - private boolean warn_this_within_closure = true; + private boolean warn_this_within_closure = false; public boolean warn_this_within_closure() { diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/clients/JSConfiguration.java b/compiler-jx/src/main/java/org/apache/royale/compiler/clients/JSConfiguration.java index c4fc0539c..13b175ad0 100644 --- a/compiler-jx/src/main/java/org/apache/royale/compiler/clients/JSConfiguration.java +++ b/compiler-jx/src/main/java/org/apache/royale/compiler/clients/JSConfiguration.java @@ -72,6 +72,7 @@ public class JSConfiguration extends Configuration setCompilerStrictIdentifierNames(null, false); setCompilerStrictFlexCSS(null, false); setCompilerAllowArrowFunctions(null, true); + setCompilerWarnThisWithinClosure(null, true); } //
