(royale-compiler) branch develop updated: IJSMetaAttributeConstants: missed adding a separate iteratorDoneMethod for JSForEachOverride

[joshtynjala]

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
     new 9dd78ef74 IJSMetaAttributeConstants: missed adding a separate 
iteratorDoneMethod for JSForEachOverride
9dd78ef74 is described below

commit 9dd78ef74a9e6192ce1b8e6185f86ebf18de73dd
Author: Josh Tynjala <joshtynj...@apache.org>
AuthorDate: Tue May 19 14:57:24 2026 -0700

    IJSMetaAttributeConstants: missed adding a separate iteratorDoneMethod for 
JSForEachOverride
    
    Was accidentally using the one for JSForInOverride instead.
    
    Followup to commit 308d8867b923c0edff4bf814fa89a175123dcf37
---
 .../org/apache/royale/compiler/constants/IJSMetaAttributeConstants.java | 1 +
 .../apache/royale/compiler/internal/codegen/js/jx/ForEachEmitter.java   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/compiler-jx/src/main/java/org/apache/royale/compiler/constants/IJSMetaAttributeConstants.java
 
b/compiler-jx/src/main/java/org/apache/royale/compiler/constants/IJSMetaAttributeConstants.java
index cd9bd1a6c..ecbb3a81f 100644
--- 
a/compiler-jx/src/main/java/org/apache/royale/compiler/constants/IJSMetaAttributeConstants.java
+++ 
b/compiler-jx/src/main/java/org/apache/royale/compiler/constants/IJSMetaAttributeConstants.java
@@ -40,6 +40,7 @@ public interface IJSMetaAttributeConstants
     static final String NAME_FOR_EACH_OVERRIDE_ITERATOR_METHOD = 
"iteratorMethod";
     static final String NAME_FOR_EACH_OVERRIDE_ITERATOR_NEXT_METHOD = 
"iteratorNextMethod";
     static final String NAME_FOR_EACH_OVERRIDE_ITERATOR_HAS_NEXT_METHOD = 
"iteratorHasNextMethod";
+    static final String NAME_FOR_EACH_OVERRIDE_ITERATOR_DONE_METHOD = 
"iteratorDoneMethod";
 
     // [JSIncludeScript]
     static final String ATTRIBUTE_INCLUDE_SCRIPT = "JSIncludeScript";
diff --git 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/ForEachEmitter.java
 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/ForEachEmitter.java
index be8d1400f..4b603b287 100644
--- 
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/ForEachEmitter.java
+++ 
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/ForEachEmitter.java
@@ -354,7 +354,7 @@ public class ForEachEmitter extends JSSubEmitter implements
         final String iteratorMethodName = 
forEachOverrideMeta.getAttributeValue(IJSMetaAttributeConstants.NAME_FOR_EACH_OVERRIDE_ITERATOR_METHOD);
         final String iteratorNextMethodName = 
forEachOverrideMeta.getAttributeValue(IJSMetaAttributeConstants.NAME_FOR_EACH_OVERRIDE_ITERATOR_NEXT_METHOD);
         final String iteratorHasNextMethodName = 
forEachOverrideMeta.getAttributeValue(IJSMetaAttributeConstants.NAME_FOR_EACH_OVERRIDE_ITERATOR_HAS_NEXT_METHOD);
-        final String iteratorDoneMethodName = 
forEachOverrideMeta.getAttributeValue(IJSMetaAttributeConstants.NAME_FOR_IN_OVERRIDE_ITERATOR_DONE_METHOD);
+        final String iteratorDoneMethodName = 
forEachOverrideMeta.getAttributeValue(IJSMetaAttributeConstants.NAME_FOR_EACH_OVERRIDE_ITERATOR_DONE_METHOD);
 
         if (iteratorMethodName == null || iteratorNextMethodName == null)
         {