[
https://issues.apache.org/jira/browse/SAMZA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381569#comment-14381569
]
Yan Fang commented on SAMZA-540:
--------------------------------
Hi [~renato2099], thanks for the contributing. Tested the patch. It did not
show the metric. That was because the OffsetManagerMetrics is not registered to
the report. Modified it a little (because those are small changes, I do not ask
you to do it back and forth. :)).
1. modified the unit test to make it test the metrics, instead of
"lastProcessedOffset"
2. registered the OffsetMetricsMetrics by using the MetricsRegistryMap that is
get reported.
Since I edited it a little, will need a +1 from other committers.
[~criccomini], since i edited the patch a little, could you have a review on
that ( i can not upload to the same RB as [~renato2099] was using)? RB:
https://reviews.apache.org/r/32528/
> Expose latency related metrics in OffsetManager
> -----------------------------------------------
>
> Key: SAMZA-540
> URL: https://issues.apache.org/jira/browse/SAMZA-540
> Project: Samza
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.8.0
> Reporter: Yan Fang
> Assignee: Renato Javier Marroquín Mogrovejo
> Labels: newbie
> Fix For: 0.10.0
>
> Attachments: SAMZA-540.1.patch, SAMZA-540.4.patch, SAMZA-540.5.patch
>
>
> Follow-up to SAMZA-503
> Expose checkpointed offset, max offset, and max offset - checkpointed offset
> metrics in OffsetManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
