[ 
https://issues.apache.org/jira/browse/SAMZA-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108062#comment-15108062
 ] 

Tao Feng commented on SAMZA-857:
--------------------------------

Hi [~navina], patch is uploaded. Thanks.

> Missing break in RocksDbOptionsHelper#options()
> -----------------------------------------------
>
>                 Key: SAMZA-857
>                 URL: https://issues.apache.org/jira/browse/SAMZA-857
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Tao Feng
>            Priority: Minor
>             Fix For: 0.10.1
>
>         Attachments: rb42485.patch
>
>
> Here is related code:
> {code}
>     case "none":
>       compressionType = CompressionType.NO_COMPRESSION;
>     default:
>       log.warn("Unknown rocksdb.compression codec " + compressionInConfig + 
> ", overwriting to Snappy");
> {code}
> Since CompressionType.NO_COMPRESSION is chosen for the "none" case, the call 
> to log.warn() shouldn't be executed.
> A break was missing for the "none" case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to