[
https://issues.apache.org/jira/browse/SAMZA-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154307#comment-15154307
]
Branislav Cogic commented on SAMZA-872:
---------------------------------------
Thanks for the assignement [~nickpan47].
I've just posted the patch for the documentation:
https://reviews.apache.org/r/43766/
> Remove unsafe log4j DailyRollingFileAppender from docs and hello-samza
> ----------------------------------------------------------------------
>
> Key: SAMZA-872
> URL: https://issues.apache.org/jira/browse/SAMZA-872
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Branislav Cogic
> Labels: newbie
> Attachments: SAMZA-872.0.patch, SAMZA-872.1.patch
>
>
> DailyRollingFileAppender is known to have synchronization issues and cause
> data loss. It even claims this in its own documentation
> https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html
> We shouldn't be referencing such a problematic appender in Samza. Instead, we
> could reference RollingFileAppender with these settings:
> <appender name="RollingAppender" class="org.apache.log4j.RollingFileAppender">
> <param name="File" value="${samza.log.dir}/${samza.container.name}.log" />
> <param name="MaxFileSize" value="256MB" />
> <param name="MaxBackupIndex" value="20" />
> <layout class="org.apache.log4j.PatternLayout">
> <param name="ConversionPattern" value="%d{yyyy-MM-dd HH:mm:ss} %c{1}
> [%p] %m%n" />
> </layout>
> </appender>
> Docs:
> https://samza.apache.org/learn/documentation/0.10/jobs/logging.html
> Hello Samza:
> https://github.com/apache/samza-hello-samza/blob/master/src/main/resources/log4j.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
