Repository: samza Updated Branches: refs/heads/master 2c9ea1a5c -> 99667d902
SAMZA-1033: Remove import-control from checkstyle Removing import-control after discussion here - [http://mail-archives.apache.org/mod_mbox/samza-dev/201607.mbox/browser](http://mail-archives.apache.org/mod_mbox/samza-dev/201607.mbox/browser) Author: Navina Ramesh <nram...@linkedin.com> Reviewers: Jagadish Venkataraman <vjagadish1...@gmail.com> Closes #17 from navina/SAMZA-1033 Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/99667d90 Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/99667d90 Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/99667d90 Branch: refs/heads/master Commit: 99667d90265e151cf89c035105a9b977bb5b9ac0 Parents: 2c9ea1a Author: Navina Ramesh <nram...@linkedin.com> Authored: Mon Oct 31 17:14:25 2016 -0700 Committer: Navina Ramesh <nram...@linkedin.com> Committed: Mon Oct 31 17:14:25 2016 -0700 ---------------------------------------------------------------------- checkstyle/checkstyle.xml | 5 - checkstyle/import-control.xml | 278 ------------------------------------- 2 files changed, 283 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/99667d90/checkstyle/checkstyle.xml ---------------------------------------------------------------------- diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml index 7bd5caa..3db0990 100644 --- a/checkstyle/checkstyle.xml +++ b/checkstyle/checkstyle.xml @@ -61,11 +61,6 @@ <module name="StaticVariableName"/> <module name="TypeName"/> - <!-- dependencies --> - <module name="ImportControl"> - <property name="file" value="${basedir}/checkstyle/import-control.xml"/> - </module> - <!-- whitespace --> <module name="GenericWhitespace"/> <module name="NoWhitespaceBefore"/> http://git-wip-us.apache.org/repos/asf/samza/blob/99667d90/checkstyle/import-control.xml ---------------------------------------------------------------------- diff --git a/checkstyle/import-control.xml b/checkstyle/import-control.xml deleted file mode 100644 index db6f859..0000000 --- a/checkstyle/import-control.xml +++ /dev/null @@ -1,278 +0,0 @@ -<!DOCTYPE import-control PUBLIC - "-//Puppy Crawl//DTD Import Control 1.1//EN" - "http://www.puppycrawl.com/dtds/import_control_1_1.dtd"> -<!-- -// Licensed to the Apache Software Foundation (ASF) under one or more -// contributor license agreements. See the NOTICE file distributed with -// this work for additional information regarding copyright ownership. -// The ASF licenses this file to You under the Apache License, Version 2.0 -// (the "License"); you may not use this file except in compliance with -// the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. ---> -<import-control pkg="org.apache.samza"> - - <!-- THINK HARD ABOUT THE LAYERING OF THE PROJECT BEFORE CHANGING THIS FILE --> - - <!-- common library dependencies --> - <allow pkg="java" /> - <allow pkg="javax.management" /> - <allow pkg="org.slf4j" /> - <allow pkg="org.junit" /> - <allow pkg="org.codehaus" /> - <allow pkg="org.mockito" /> - <allow pkg="org.apache.log4j" /> - <allow pkg="org.apache.kafka" /> - <allow pkg="org.apache.commons" /> - <allow class="scala.collection.JavaConversions" /> - <allow class="scala.collection.JavaConverters" /> - <allow class="scala.Option" /> - <allow pkg="scala.runtime" /> - - <subpackage name="config"> - <allow class="org.apache.samza.SamzaException" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.util" /> - - <allow class="org.apache.samza.Partition" /> - </subpackage> - - <subpackage name="clustermanager"> - <allow class="org.apache.samza.SamzaException" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.coordinator" /> - <allow pkg="org.apache.samza.job" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.serializers" /> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.eclipse.jetty.servlet" /> - - - <allow class="org.apache.samza.Partition" /> - </subpackage> - - - <subpackage name="serializers"> - <allow pkg="org.apache.samza.config" /> - - <subpackage name="model"> - <allow pkg="org.apache.samza.job.model" /> - <allow pkg="org.apache.samza.util" /> - - <allow class="org.apache.samza.Partition" /> - <allow class="org.apache.samza.container.TaskName" /> - <allow class="org.apache.samza.system.SystemStreamPartition" /> - </subpackage> - </subpackage> - - <subpackage name="migration"> - <allow pkg="org.apache.samza.config" /> - </subpackage> - - <subpackage name="job"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.coordinator.stream" /> - <allow pkg="org.apache.samza.metrics" /> - <allow class="org.apache.samza.system.SystemStreamPartitionIterator" /> - <allow class="org.apache.samza.container.SamzaContainer" /> - <allow pkg="org.apache.samza.job.model" /> - <subpackage name="model"> - <allow pkg="org.apache.samza.coordinator.stream.messages" /> - - <allow class="org.apache.samza.Partition" /> - <allow class="org.apache.samza.container.TaskName" /> - <allow class="org.apache.samza.system.SystemStreamPartition" /> - <allow class="org.apache.samza.container.LocalityManager" /> - </subpackage> - </subpackage> - - <subpackage name="system"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.serializers" /> - - <allow class="org.apache.samza.Partition" /> - <allow class="org.apache.samza.SamzaException" /> - - <subpackage name="chooser"> - <allow class="org.apache.samza.system.SystemStreamPartition" /> - <allow class="org.apache.samza.system.IncomingMessageEnvelope" /> - </subpackage> - - <subpackage name="mock"> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.util" /> - </subpackage> - </subpackage> - - <subpackage name="util"> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="junit.framework" /> - - <allow class="org.apache.samza.Partition" /> - <allow class="org.apache.samza.SamzaException" /> - <allow class="joptsimple.OptionSet" /> - </subpackage> - - <subpackage name="metrics"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.container" /> - </subpackage> - - <subpackage name="task"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.checkpoint" /> - <allow class="org.apache.samza.SamzaException" /> - <allow class="org.apache.samza.Partition" /> - </subpackage> - - <subpackage name="container"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.apache.samza.coordinator.stream" /> - <allow pkg="com.google.common" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="junit.framework" /> - <allow class="org.apache.samza.coordinator.stream.AbstractCoordinatorStreamManager" /> - <allow class="org.apache.samza.SamzaException" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.task" /> - <allow pkg="org.apache.samza.util" /> - <subpackage name="grouper"> - <subpackage name="stream"> - <allow pkg="org.apache.samza.system" /> - <allow class="org.apache.samza.Partition" /> - </subpackage> - - <subpackage name="task"> - <allow pkg="org.apache.samza.job" /> - </subpackage> - </subpackage> - <subpackage name="mock"> - <allow class="org.apache.samza.container.TaskName" /> - <allow pkg="org.apache.samza.job.model" /> - <allow class="org.apache.samza.Partition" /> - <allow pkg="org.apache.samza.system" /> - </subpackage> - </subpackage> - - <subpackage name="coordinator"> - <allow pkg="org.apache.samza.checkpoint" /> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.serializers" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.coordinator.stream.messages" /> - - <allow class="org.apache.samza.Partition" /> - <allow class="org.apache.samza.SamzaException" /> - <allow class="joptsimple.OptionSet" /> - <allow class="org.apache.samza.container.TaskName" /> - </subpackage> - - <subpackage name="checkpoint"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.apache.samza.coordinator" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.system" /> - - <allow class="org.apache.samza.SamzaException" /> - <allow class="org.apache.samza.coordinator.stream.AbstractCoordinatorStreamManager" /> - </subpackage> - - <subpackage name="storage"> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.apache.samza.coordinator" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.serializers" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.task" /> - <allow class="org.apache.samza.coordinator.stream.AbstractCoordinatorStreamManager" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.job" /> - <allow pkg="org.apache.samza.config" /> - <allow pkg="joptsimple" /> - - <allow class="org.apache.samza.SamzaException" /> - <allow class="org.apache.samza.Partition" /> - - <subpackage name="kv"> - <allow pkg="org.apache.samza.storage" /> - </subpackage> - </subpackage> - - <subpackage name="logging"> - <subpackage name="log4j"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.coordinator" /> - <allow pkg="org.apache.samza.job" /> - <allow pkg="org.apache.samza.metrics" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.serializers" /> - <allow pkg="org.apache.samza.util" /> - - <allow class="org.apache.samza.logging.log4j.serializers.LoggingEventJsonSerdeFactory" /> - <allow class="org.apache.samza.logging.log4j.serializers.LoggingEventJsonSerde" /> - <allow class="org.apache.samza.logging.log4j.serializers.LoggingEventStringSerdeFactory" /> - <allow class="org.apache.samza.logging.log4j.serializers.LoggingEventStringSerde" /> - <allow class="org.apache.samza.SamzaException" /> - </subpackage> - </subpackage> - - <subpackage name="test"> - <subpackage name="integration"> - <allow pkg="org.apache.samza.config" /> - <allow pkg="org.apache.samza.container" /> - <allow pkg="org.apache.samza.system" /> - <allow pkg="org.apache.samza.storage" /> - <allow pkg="org.apache.samza.task" /> - <allow pkg="org.apache.samza.util" /> - </subpackage> - </subpackage> - - - <subpackage name="manager"> - <allow pkg="org.apache.samza.coordinator.stream" /> - <allow class="org.apache.samza.container.TaskName" /> - </subpackage> - - <subpackage name="autoscaling"> - <subpackage name="deployer"> - <allow pkg="org.apache.samza.coordinator.stream" /> - <allow pkg="org.apache.samza.util" /> - <allow pkg="org.apache.samza.autoscaling.utils" /> - - <allow class="org.apache.samza.config.Config" /> - <allow class="org.apache.samza.config.JobConfig" /> - <allow class="org.apache.samza.container.SamzaContainer" /> - <allow class="org.apache.samza.job.JobRunner" /> - <allow class="org.apache.samza.job.model.ContainerModel" /> - <allow class="org.apache.samza.metrics.MetricsRegistryMap" /> - <allow class="org.apache.samza.system.SystemStreamPartitionIterator" /> - <allow class="org.apache.hadoop.yarn.exceptions.YarnException" /> - <allow class="joptsimple.OptionSet" /> - </subpackage> - <subpackage name="utils"> - <allow pkg="org.apache.hadoop.yarn" /> - <allow pkg="org.apache.http" /> - </subpackage> - </subpackage> - -</import-control>