[
https://issues.apache.org/jira/browse/SAMZA-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958145#comment-15958145
]
ASF GitHub Bot commented on SAMZA-1191:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/113
SAMZA-1191: Fixed flaky test: TestExponentialSleepStrategy
testThreadInterruptInRetryLoop
It's possible that the interruptee thread (see `#interruptedThread`) gets
pre-empted before it has a chance to run the operation (increment `iterations`)
and then gets interrupted, causing these assertions to fail.
I think these assertions also aren't critical for the tests which I presume
want to test interrupt propagation behavior, so removing them in this change.
@vjagadish1989 & @xinyuiscool, please take a look.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza flaky-ess-test-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 802d6a913d729b9fe4427fde81683bbaca401d1c
Author: Prateek Maheshwari <pmahe...@linkedin.com>
Date: 2017-04-06T01:08:12Z
SAMZA-1191: Fixed flaky test: TestExponentialSleepStrategy
testThreadInterruptInRetryLoop
----
> Flaky test: TestExponentialSleepStrategy testThreadInterruptInRetryLoop
> -----------------------------------------------------------------------
>
> Key: SAMZA-1191
> URL: https://issues.apache.org/jira/browse/SAMZA-1191
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Prateek Maheshwari
> Fix For: 0.13.0
>
>
> Failed on Jenkins during PR validation. Error log:
> :samza-core_2.11:test
> testThreadInterruptInRetryLoop FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.failNotEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:126)
> at org.junit.Assert.assertEquals(Assert.java:470)
> at org.junit.Assert.assertEquals(Assert.java:454)
> at
> org.apache.samza.util.TestExponentialSleepStrategy.testThreadInterruptInRetryLoop(TestExponentialSleepStrategy.scala:143)
> 456 tests completed, 1 failed, 1 skipped
> :samza-core_2.11:test FAILED
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
