[ 
https://issues.apache.org/jira/browse/SAMZA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227190#comment-16227190
 ] 

ASF GitHub Bot commented on SAMZA-1477:
---------------------------------------

GitHub user xinyuiscool opened a pull request:

    https://github.com/apache/samza/pull/345

    SAMZA-1477: Fix issues found by BEAM tests

    A bunch of issues were found by BEAM tests, which includes:
    
    1) WatermarkFunction needs to be able to return output after 
processWatermark()
    2) control message doesn't implement the equals() and hashcode()
    3) Some kafka system related code is not scala 2.10 compatible for tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xinyuiscool/samza SAMZA-1477

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #345
    
----
commit 735f4b966b19521c3d7003c25209f5344f0fb6c3
Author: xiliu <xi...@xiliu-ld1.linkedin.biz>
Date:   2017-10-31T17:41:56Z

    SAMZA-1477: Fix issues found by BEAM tests

----


> Fix issues found by BEAM tests
> ------------------------------
>
>                 Key: SAMZA-1477
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1477
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Xinyu Liu
>            Assignee: Xinyu Liu
>
> A bunch of issues were found by BEAM tests, which includes:
> 1) WatermarkFunction needs to be able to return output after 
> processWatermark()
> 2) control message doesn't implement the equals() and hashcode()
> 3) Some kafka system related code is not scala 2.10 compatible for tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to