[
https://issues.apache.org/jira/browse/SAMZA-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340404#comment-16340404
]
ASF GitHub Bot commented on SAMZA-1548:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/samza/pull/397
> Add start() and stop() to SystemAdmin
> -------------------------------------
>
> Key: SAMZA-1548
> URL: https://issues.apache.org/jira/browse/SAMZA-1548
> Project: Samza
> Issue Type: Bug
> Reporter: Dong Lin
> Assignee: Dong Lin
> Priority: Major
> Fix For: 0.15.0
>
>
> This patch adds start() and stop() to SystemAdmin interface. This can be
> useful for e.g. kafka.admin.AdminClient which needs to be started before it
> can be used.
> Since we add this method in interface and expect AdminClient to be stateful
> and probably has its own thread, there will be higher cost to instantiate a
> new SystemAdmin. Thus we probably want to re-use the SystemAdmin instances
> instead of creating SystemAdmin on demand when needed. Therefore, this patch
> also adds SystemAdmins class to help manage a map from system to SystemAdmin,
> similar to the existing SystemProducers class in Samza.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
