[
https://issues.apache.org/jira/browse/SAMZA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433230#comment-16433230
]
ASF GitHub Bot commented on SAMZA-1643:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/468
SAMZA-1643: StreamPartitionCountMonitor should only restart/shut down the
job if partition count increases
As an aside, also update the gauge to report current number of partitions
instead of the change, since that's what its name indicates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza partition-monitor-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #468
----
commit 5f120152c3ad36c80caebfff24925118e1a4ab7c
Author: Prateek Maheshwari <pmaheshw@...>
Date: 2018-04-11T00:35:58Z
SAMZA-1643: StreamPartitionCountMonitor should only restart/shut down the
job if partition count increases
----
> StreamPartitionCountMonitor should only restart/shut down the job if
> partition count increases
> ----------------------------------------------------------------------------------------------
>
> Key: SAMZA-1643
> URL: https://issues.apache.org/jira/browse/SAMZA-1643
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Assignee: Prateek Maheshwari
> Priority: Major
>
> Make StreamPartitionCountMonitor less aggressive and only restart (stateless)
> or shut down (stateful) the job if partition count increases.
> In some versions of KafkaConsumer, partitionFor(topic) can return a count
> lower than the configured number of partitions if the broker it asks has
> recently restarted.
> The only downside of not restarting the job on partition count decreases is
> that some containers may be idle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
