[
https://issues.apache.org/jira/browse/SAMZA-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491461#comment-16491461
]
ASF GitHub Bot commented on SAMZA-1731:
---------------------------------------
GitHub user shanthoosh opened a pull request:
https://github.com/apache/samza/pull/536
SAMZA-1731: Daemonize threads spawned from SamzaEventHubClientManager.
**Problem:**
Existing SamzaEventHubClientManager implementation spawns non-daemon
threads when instantiating EventHubClient. These non-daemon threads stalls
shutdown of samza processes even when the main thread has exited.
**Fix:**
Daemonize threads that are spawned from SamzaEventHubClientManager.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shanthoosh/samza SAMZA-1731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #536
----
commit 9065861972c277242bf5a4f8b7d6132468ff6fea
Author: Shanthoosh Venkataraman <santhoshvenkat1988@...>
Date: 2018-05-26T02:01:31Z
SAMZA-1731: Daemonize threads spawned from SamzaEventHubClientManager.
----
> Daemonize threads spawned from SamzaEventHubClientManager.
> ----------------------------------------------------------
>
> Key: SAMZA-1731
> URL: https://issues.apache.org/jira/browse/SAMZA-1731
> Project: Samza
> Issue Type: Bug
> Reporter: Shanthoosh Venkataraman
> Assignee: Shanthoosh Venkataraman
> Priority: Major
>
> *Problem:*
> Existing SamzaEventHubClientManager implementation spawns non-daemon threads
> when instantiating EventHubClient.
> These non-daemon threads stalls shutdown of samza processes even when the
> main thread has exited.
> This has proven to cause problem in linkedin production envrionment and force
> kill is required to stop samza processors.
> *Fix:*
> Daemonize threads that are spawned from SamzaEventHubClientManager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
