[
https://issues.apache.org/jira/browse/SAMZA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493949#comment-16493949
]
ASF GitHub Bot commented on SAMZA-1724:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/538
SAMZA-1724: Guarantee exit from ApplicationRunnerMain during deploys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza process-exit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #538
----
commit b9d161c00505419aada2249632877c94b1a6f70d
Author: Prateek Maheshwari <pmaheshw@...>
Date: 2018-05-29T17:48:13Z
SAMZA-1724: Guarantee exit from ApplicationRunnerMain during deploys
----
> Guarantee exit from ApplicationRunnerMain during deploys
> --------------------------------------------------------
>
> Key: SAMZA-1724
> URL: https://issues.apache.org/jira/browse/SAMZA-1724
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Assignee: Prateek Maheshwari
> Priority: Major
>
> When running in YARN, control script runs ApplicationRunnerMain to
> start/stop/get status for jobs. It parses the output of the process after it
> exits and looks for a particular string to check job status.
> Currently ApplicationRunnerMain's main method just returns at the end of
> execution. This can cause the process to get stuck (i.e. not exit) if there
> are still non-daemon threads running becuase some code didn't't shut down its
> executor services during shutdown.
> We should directly exit with System.exit(0) at the end of main to guarantee
> shutdown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
