[ https://issues.apache.org/jira/browse/SAMZA-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581732#comment-16581732 ]
ASF GitHub Bot commented on SAMZA-1807: --------------------------------------- GitHub user pdu-mn1 opened a pull request: https://github.com/apache/samza/pull/608 SAMZA-1807 table-api: inline async helpers Currently we have a set of helper methods, execute() for various table access methods. Some of them are only called by one place and some are called in two places. This change inlines the async handling back to the table methods and removed the helpers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdu-mn1/samza inline-async Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #608 ---- commit fd4ed5354b3c4c0b1343a6d0ea98ced300873e80 Author: Peng Du <pdu@...> Date: 2018-08-15T21:49:35Z SAMZA-1807 table-api: inline async helpers Currently we have a set of helper methods, execute() for various table access methods. Some of them are only called by one place and some are called in two places. This change inlines the async handling back to the table methods and removed the helpers. ---- > Create specific execute() for each async table API > -------------------------------------------------- > > Key: SAMZA-1807 > URL: https://issues.apache.org/jira/browse/SAMZA-1807 > Project: Samza > Issue Type: Improvement > Components: kv > Reporter: Peng Du > Assignee: Peng Du > Priority: Minor > Labels: newbie, newbie++, table-api > > Right now we have to pass a bunch of member variables to the execute() > methods in RemoteReadable and RemoteReadWriteTable. This can be avoided if we > have separate execute methods per async method, which we already have three > of them, key, key+value, records. The first one is shared by get and delete. > If we create a separate one for delete then we can avoid passing the > variables. -- This message was sent by Atlassian JIRA (v7.6.3#76005)