[
https://issues.apache.org/jira/browse/SAMZA-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648323#comment-16648323
]
ASF GitHub Bot commented on SAMZA-1937:
---------------------------------------
GitHub user weiqingy opened a pull request:
https://github.com/apache/samza/pull/721
SAMZA-1937: Make DSL converter work when sql is a query
## What changes were proposed in this pull request?
To support the use case that users use Samza Sql Console or Samza Sql shell
to perform SELECT query.
## How was this patch tested?
1. Build passed and current unit tests passed
2. Testing in Samza Sql shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weiqingy/samza SAMZA-1937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/721.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #721
----
commit 423ee0d742e19cbc3db4d5e333717ec88ffb7224
Author: Weiqing Yang <yangweiqing001@...>
Date: 2018-09-22T22:01:51Z
make DSL converter work when sql is a query
commit 1663115d761b667755c13850671e7baf8629914f
Author: Weiqing Yang <yangweiqing001@...>
Date: 2018-10-08T18:13:56Z
fix review comments
commit 2d5491284ae6d7aee46d7115476d055309f10a0d
Author: Weiqing Yang <yangweiqing001@...>
Date: 2018-10-10T23:46:35Z
Fix review comments
----
> Enable users to perform Sql queries (SELECT statement)
> ------------------------------------------------------
>
> Key: SAMZA-1937
> URL: https://issues.apache.org/jira/browse/SAMZA-1937
> Project: Samza
> Issue Type: Bug
> Components: sql
> Reporter: Weiqing Yang
> Priority: Major
> Fix For: 0.15.0
>
>
> Current DSL converter does not support the use case that users use Samza Sql
> Console or Samza Sql shell to perform SELECT query. The reason is
> "log.outputStream" does not have schema while Calcite asks for its schema
> when Calcite do validation for the Sql statement (we only passed selectQuery
> to Calcite before, but now we pass the whole sql to Calcite). Also, it seems
> "log.outputStream" does not work with ModifyTranslator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
