[ https://issues.apache.org/jira/browse/SAMZA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654383#comment-16654383 ]
ASF GitHub Bot commented on SAMZA-1888: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/samza/pull/738 > minor improvements for the after commit for KafkaSystemAdmin and > KafkaSystemConsumer. > ------------------------------------------------------------------------------------- > > Key: SAMZA-1888 > URL: https://issues.apache.org/jira/browse/SAMZA-1888 > Project: Samza > Issue Type: Bug > Reporter: Boris Shkolnik > Assignee: Boris Shkolnik > Priority: Major > > consider documents on the following: > # usage of zookeeper connect, still needed for AdminClient (not for > KafkaConsumer) > # timeout for the Kafka client > # buffer size for Kafka Client > # Create a separate class to handle JobName and JobId together (extend > Pair<String, String> ?) > # update documentation for new KafkaSystemConsumer (change in configs) > # review KafkaSystemAdmin.start() usage. > # create kafka's AdminClient lazily -- This message was sent by Atlassian JIRA (v7.6.3#76005)