[ https://issues.apache.org/jira/browse/SAMZA-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Nishimura updated SAMZA-2143: ------------------------------------ Description: NPE exposed in CoordinatorStreamMessage#equals now that the metadata store allows arbitrary messages to be stored in the coordinator stream. See below for example NPE stack trace. In CoordinatorStreamSystemConsumer, remove unused getBootstrappedStream overloaded method and unit test the appropriate method that's actually used in non-test code. Example NPE error: {code:java} Exception in thread "main" org.apache.samza.SamzaException: Failed to run application at org.apache.samza.runtime.RemoteApplicationRunner.run(RemoteApplicationRunner.java:79) at org.apache.samza.runtime.ApplicationRunnerUtil.invoke(ApplicationRunnerUtil.java:54) at org.apache.samza.runtime.ApplicationRunnerMain.main(ApplicationRunnerMain.java:53) Caused by: org.apache.samza.SamzaException: java.lang.NullPointerException at org.apache.samza.coordinator.stream.CoordinatorStreamSystemConsumer.bootstrap(CoordinatorStreamSystemConsumer.java:200) at org.apache.samza.job.JobRunner.run(JobRunner.scala:107) at org.apache.samza.runtime.RemoteApplicationRunner.lambda$run$0(RemoteApplicationRunner.java:76) at java.util.ArrayList.forEach(ArrayList.java:1257) at org.apache.samza.runtime.RemoteApplicationRunner.run(RemoteApplicationRunner.java:73) ... 2 more Caused by: java.lang.NullPointerException at org.apache.samza.coordinator.stream.messages.CoordinatorStreamMessage.equals(CoordinatorStreamMessage.java:315) at java.util.HashMap.removeNode(HashMap.java:820) at java.util.HashMap.remove(HashMap.java:799) at java.util.HashSet.remove(HashSet.java:236) at org.apache.samza.coordinator.stream.CoordinatorStreamSystemConsumer.bootstrap(CoordinatorStreamSystemConsumer.java:181) ... 6 more {code} was: NPE exposed in CoordinatorStreamMessage#equals now that the metadata store allows arbitrary messages to be stored in the coordinator stream. See below for example NPE stack trace. In CoordinatorStreamSystemConsumer, remove unused getBootstrappedStream overloaded method and unit test the appropriate method that's actually used in non-test code. > NPE in CoordinatorStreamMessage#equals and some clean-up to > CoordinatorStreamSystemConsumer > ------------------------------------------------------------------------------------------- > > Key: SAMZA-2143 > URL: https://issues.apache.org/jira/browse/SAMZA-2143 > Project: Samza > Issue Type: Bug > Affects Versions: 1.1 > Reporter: Daniel Nishimura > Assignee: Daniel Nishimura > Priority: Major > > NPE exposed in CoordinatorStreamMessage#equals now that the metadata store > allows arbitrary messages to be stored in the coordinator stream. See below > for example NPE stack trace. > In CoordinatorStreamSystemConsumer, remove unused getBootstrappedStream > overloaded method and unit test the appropriate method that's actually used > in non-test code. > Example NPE error: > {code:java} > Exception in thread "main" org.apache.samza.SamzaException: Failed to run > application > at > org.apache.samza.runtime.RemoteApplicationRunner.run(RemoteApplicationRunner.java:79) > at > org.apache.samza.runtime.ApplicationRunnerUtil.invoke(ApplicationRunnerUtil.java:54) > at > org.apache.samza.runtime.ApplicationRunnerMain.main(ApplicationRunnerMain.java:53) > Caused by: org.apache.samza.SamzaException: java.lang.NullPointerException > at > org.apache.samza.coordinator.stream.CoordinatorStreamSystemConsumer.bootstrap(CoordinatorStreamSystemConsumer.java:200) > at org.apache.samza.job.JobRunner.run(JobRunner.scala:107) > at > org.apache.samza.runtime.RemoteApplicationRunner.lambda$run$0(RemoteApplicationRunner.java:76) > at java.util.ArrayList.forEach(ArrayList.java:1257) > at > org.apache.samza.runtime.RemoteApplicationRunner.run(RemoteApplicationRunner.java:73) > ... 2 more > Caused by: java.lang.NullPointerException > at > org.apache.samza.coordinator.stream.messages.CoordinatorStreamMessage.equals(CoordinatorStreamMessage.java:315) > at java.util.HashMap.removeNode(HashMap.java:820) > at java.util.HashMap.remove(HashMap.java:799) > at java.util.HashSet.remove(HashSet.java:236) > at > org.apache.samza.coordinator.stream.CoordinatorStreamSystemConsumer.bootstrap(CoordinatorStreamSystemConsumer.java:181) > ... 6 more > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)