cameronlee314 edited a comment on issue #1010: SAMZA-2176: Ignore the keys with serialized null values from the coordinator stream. URL: https://github.com/apache/samza/pull/1010#issuecomment-487218020 > @cameronlee314 > > For non-config cases, old 1.0 logic did not do the null checks. > > This whole PR was necessary because coordinator stream was corrupted with serialized null values for config-type keys. The same serialized-null values can be published to coordinator stream for any type of keys(container-host, task-partition) in the future. > > I'm adding this null-checks as a safe-guard to prevent against it. I suggest doing these two changes in separate PRs. First PR to just fix the config case to bring it back to Samza 1.0 functionality. Second PR to add the safe guards. Then we can manage the changes separately (e.g. if it turns out that the extra non-config safe guards are undesirable, we don't want to roll back the config changes). One of the goals of this change was to get back to Samza 1.0 functionality, but this PR doesn't quite do that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
