cameronlee314 commented on a change in pull request #1001: SAMZA-2168: Remove
redundant SystemAdmin creation in ApplicationMaster
URL: https://github.com/apache/samza/pull/1001#discussion_r279139090
##########
File path:
samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala
##########
@@ -283,7 +283,9 @@ class StreamTaskTestUtil {
case _ => assert(checkpointManager != null, "No checkpoint manager
factory configured")
}
- ChangelogStreamManager.createChangelogStreams(jobModel.getConfig,
jobModel.maxChangeLogStreamPartitions)
+ val systemAdmins = new SystemAdmins(mapConfig)
+ systemAdmins.start()
Review comment:
Need to call `stop`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
