cameronlee314 commented on a change in pull request #1006: SAMZA-2171 :
Implement MetadataResourceManager to encapsulate loading of metadata resources
URL: https://github.com/apache/samza/pull/1006#discussion_r279497454
##########
File path:
samza-core/src/test/java/org/apache/samza/coordinator/TestMetadataResourceUtil.java
##########
@@ -20,24 +20,30 @@
package org.apache.samza.coordinator;
import org.apache.samza.checkpoint.CheckpointManager;
+import org.apache.samza.job.model.JobModel;
+import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+public class TestMetadataResourceUtil {
+ private CheckpointManager checkpointManager;
+ private JobModel jobModel;
-public class TestMetadataResourceManager {
+ @Before
+ public void setUp() {
+ checkpointManager = Mockito.mock(CheckpointManager.class);
+ jobModel = Mockito.mock(JobModel.class);
+ }
@Test
public void testLoad() {
- CheckpointManager checkpointManager =
Mockito.mock(CheckpointManager.class);
- MetadataResourceManager metadataResourceManager =
Mockito.mock(MetadataResourceManager.class);
- Mockito.doCallRealMethod().when(metadataResourceManager).createResources();
-
Mockito.doReturn(checkpointManager).when(metadataResourceManager).getCheckpointManager();
- Mockito.doNothing().when(metadataResourceManager).createChangelogStreams();
+ MetadataResourceUtil metadataResourceUtil = Mockito.spy(new
MetadataResourceUtil(checkpointManager, jobModel));
+ Mockito.doCallRealMethod().when(metadataResourceUtil).createResources();
Review comment:
You don't need to do `doCallReadMethod` for `spy` objects. As long as you
don't stub a method on a `spy`, it will call the real method by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
