prateekm commented on a change in pull request #1039: SAMZA-2197: [Scala
cleanup] Convert TaskConfig to Java
URL: https://github.com/apache/samza/pull/1039#discussion_r290431383
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -401,7 +399,8 @@ object SamzaContainer extends Logging {
info("Setting up message chooser.")
- val chooserFactoryClassName =
config.getMessageChooserClass.getOrElse(classOf[RoundRobinChooserFactory].getName)
+ val taskConfig = new TaskConfig(config)
+ val chooserFactoryClassName =
taskConfig.getMessageChooserClass.orElse(classOf[RoundRobinChooserFactory].getName)
Review comment:
Minor: Maybe make this the default value in the class itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
