prateekm commented on a change in pull request #1039: SAMZA-2197: [Scala
cleanup] Convert TaskConfig to Java
URL: https://github.com/apache/samza/pull/1039#discussion_r291300188
##########
File path:
samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala
##########
@@ -273,14 +274,13 @@ class StreamTaskTestUtil {
val jobModel = new JobModel(mapConfig, containers)
jobModel.maxChangeLogStreamPartitions = 1
- val taskConfig = new TaskConfigJava(jobModel.getConfig)
- val checkpointManager = Option(taskConfig.getCheckpointManager(new
MetricsRegistryMap(), getClass.getClassLoader))
- checkpointManager match {
- case Some(checkpointManager) => {
- checkpointManager.createResources
- checkpointManager.stop
- }
- case _ => assert(checkpointManager != null, "No checkpoint manager
factory configured")
+ val taskConfig = new TaskConfig(jobModel.getConfig)
+ JavaOptionals.toRichOptional(taskConfig.getCheckpointManager(new
MetricsRegistryMap(), getClass.getClassLoader))
+ .toOption match {
+ case Some(checkpointManager) =>
Review comment:
Nitpick: formatting / indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
