cameronlee314 commented on a change in pull request #1040: SAMZA-2199: [Scala
cleanup] Convert MetricsConfig to Java
URL: https://github.com/apache/samza/pull/1040#discussion_r292192065
##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -122,6 +122,8 @@ public MetadataFileContents(String version, String
metricsSnapshot) {
DiagnosticsManager diagnosticsManager = new DiagnosticsManager(jobName,
jobId, containerId, execEnvContainerId.orElse(""), taskClassVersion,
samzaVersion, hostName, diagnosticsSystemStream, systemProducer,
Duration.ofMillis(new TaskConfig(config).getShutdownMs()));
+ Option<String> blacklist =
ScalaJavaUtil.JavaOptionals$.MODULE$.toRichOptional(
Review comment:
That's what I tried initially, but the IDE complains that it can't find
`JavaOptionals` when doing that. Looks like this `MODULE$` syntax is used in
some other places too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
