[samza] branch master updated: SAMZA-2262: Change container-startup-time to a gauge from a timer and to ms instead of ns (#1092)

[pmaheshwari]

This is an automated email from the ASF dual-hosted git repository.

pmaheshwari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git


The following commit(s) were added to refs/heads/master by this push:
     new 816313e  SAMZA-2262: Change container-startup-time to a gauge from a 
timer and to ms instead of ns (#1092)
816313e is described below

commit 816313e04c6aea1bc95ed813f0a7ee0b86b9ca02
Author: rmatharu <40646191+rmath...@users.noreply.github.com>
AuthorDate: Wed Jun 26 19:03:23 2019 -0700

    SAMZA-2262: Change container-startup-time to a gauge from a timer and to ms 
instead of ns (#1092)
    
    * Making container-startup-time a gauge. It is currently a timer.
    * Using long-gauge for container-startup-time
    * Converting startup time to millis
---
 .../src/main/scala/org/apache/samza/container/SamzaContainer.scala      | 2 +-
 .../main/scala/org/apache/samza/container/SamzaContainerMetrics.scala   | 2 +-
 .../src/test/scala/org/apache/samza/container/TestSamzaContainer.scala  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
b/samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
index a90ab93..db8dbae 100644
--- a/samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
+++ b/samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
@@ -758,7 +758,7 @@ class SamzaContainer(
       if (containerListener != null) {
         containerListener.afterStart()
       }
-      metrics.containerStartupTime.update(System.nanoTime() - startTime)
+      metrics.containerStartupTime.set((System.nanoTime() - startTime)/1000000)
       if (taskInstances.size > 0)
         runLoop.run
       else
diff --git 
a/samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
 
b/samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
index 56f2ab6..1beb3dd 100644
--- 
a/samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
+++ 
b/samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
@@ -40,7 +40,7 @@ class SamzaContainerMetrics(
   val processNs = newTimer("process-ns")
   val commitNs = newTimer("commit-ns")
   val blockNs = newTimer("block-ns")
-  val containerStartupTime = newTimer("container-startup-time")
+  val containerStartupTime = newGauge("container-startup-time", 0L)
   val utilization = newGauge("event-loop-utilization", 0.0F)
   val diskUsageBytes = newGauge("disk-usage-bytes", 0L)
   val diskQuotaBytes = newGauge("disk-quota-bytes", Long.MaxValue)
diff --git 
a/samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 
b/samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
index 0d267a1..47eb2a4 100644
--- 
a/samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
+++ 
b/samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
@@ -80,7 +80,7 @@ class TestSamzaContainer extends AssertionsForJUnit with 
MockitoSugar {
   def setup(): Unit = {
     MockitoAnnotations.initMocks(this)
     setupSamzaContainer(Some(this.applicationContainerContext))
-    when(this.metrics.containerStartupTime).thenReturn(mock[Timer])
+    when(this.metrics.containerStartupTime).thenReturn(mock[Gauge[Long]])
   }
 
   @Test