xinyuiscool commented on a change in pull request #1078: SAMZA-2248: Fix AM
bookkeeping on receiving dead container notifications
URL: https://github.com/apache/samza/pull/1078#discussion_r298367159
##########
File path:
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerRequestState.java
##########
@@ -193,4 +193,28 @@ public void testContainerAssignment() throws Exception {
}
+ @Test
Review comment:
I think the scope of the change is quite limited so this test should cover
it. The change does not affect the allocator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
