sborya commented on a change in pull request #1078: SAMZA-2248: Fix AM
bookkeeping on receiving dead container notifications
URL: https://github.com/apache/samza/pull/1078#discussion_r298751679
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java
##########
@@ -229,6 +230,25 @@ public int releaseExtraResources() {
}
}
+ /**
+ * Releases a single resource based on containerId.
+ * @param containerId Yarn container ID
+ */
+ public void releaseResource(String containerId) {
+ if (StringUtils.isEmpty(containerId)) {
+ log.warn("ContainerId is not specified");
Review comment:
please add "ContainerId is not specified" 'in ClusterManager release
resource'.
Without the context the message may be to vague.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
