cameronlee314 commented on a change in pull request #1126: Adding two
additional params to DiagnosticsStreamMessage
URL: https://github.com/apache/samza/pull/1126#discussion_r311157715
##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -101,6 +101,8 @@ public MetadataFileContents(String version, String
metricsSnapshot) {
ClusterManagerConfig clusterManagerConfig = new
ClusterManagerConfig(config);
int containerMemoryMb = clusterManagerConfig.getContainerMemoryMb();
int containerNumCores = clusterManagerConfig.getNumCores();
+ long maxHeapSizeBytes = Runtime.getRuntime().maxMemory();
+ int containerThreadPoolSize = new JobConfig(config).getThreadPoolSize();
Review comment:
There is a usage of `JobConfig` above on line 99. Could you please create
one `JobConfig` and reuse it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
