shanthoosh commented on a change in pull request #1132: SAMZA-2296: Metadata
streams not created in Standalone
URL: https://github.com/apache/samza/pull/1132#discussion_r312586817
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/MetadataResourceUtil.java
##########
@@ -62,7 +59,13 @@ public void createResources() {
createChangelogStreams();
}
+ @VisibleForTesting
void createChangelogStreams() {
- ChangelogStreamManager.createChangelogStreams(jobModel.getConfig(),
jobModel.maxChangeLogStreamPartitions);
+ ChangelogStreamManager.createChangelogStreams(config,
jobModel.maxChangeLogStreamPartitions);
Review comment:
Would be great if we can log a message at appropriate level that we're
creating the change-log and checkpoint stream. Currently it is not being logged
anywhere, so it'll be useful during debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
