dengpanyin commented on a change in pull request #1144: SAMZA-2309: Remove
readFn requirement for remote tables
URL: https://github.com/apache/samza/pull/1144#discussion_r317253899
##########
File path:
samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java
##########
@@ -345,7 +346,6 @@ public String getProviderFactoryClassName() {
@Override
protected void validate() {
- Preconditions.checkNotNull(readFn, "TableReadFunction is required.");
Review comment:
Thanks for the change!
should we validate at least a readfn or writefn exist?
Also, The constructor of RemoteTable and AsyncRemoteTable also has
validations that readfn is required. Purely remove the validation here may not
be enough.
After this change, it's possible unit/regression test may fail, need to fix
as well if any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
