rmatharu commented on a change in pull request #1145: Emitting numPersistentStores instead of num stores with changelog from DiagnosticsManager URL: https://github.com/apache/samza/pull/1145#discussion_r317370802
########## File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java ########## @@ -55,7 +55,7 @@ private static final String STOP_EVENT_LIST_METRIC_NAME = "stopEvents"; private static final String CONTAINER_MB_METRIC_NAME = "containerMemoryMb"; private static final String CONTAINER_NUM_CORES_METRIC_NAME = "containerNumCores"; - private static final String CONTAINER_NUM_STORES_WITH_CHANGELOG_METRIC_NAME = "numStoresWithChangelog"; Review comment: Yup, only the asc prototype uses this currently. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
