[samza] branch master updated: SAMZA-2311 : Removing use of logger from appender (#1146)

[rayman]

This is an automated email from the ASF dual-hosted git repository.

rayman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git


The following commit(s) were added to refs/heads/master by this push:
     new 767a5d4  SAMZA-2311 : Removing use of logger from appender (#1146)
767a5d4 is described below

commit 767a5d47400948f56158d4c7307a91ef0baff4b4
Author: rmatharu <40646191+rmath...@users.noreply.github.com>
AuthorDate: Mon Aug 26 13:35:27 2019 -0700

    SAMZA-2311 : Removing use of logger from appender (#1146)
---
 .../apache/samza/logging/log4j/SimpleDiagnosticsAppender.java  | 10 ++--------
 .../apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java | 10 ++--------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git 
a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java
 
b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java
index 95135b2..4aed996 100644
--- 
a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java
+++ 
b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/SimpleDiagnosticsAppender.java
@@ -23,8 +23,6 @@ import org.apache.log4j.AppenderSkeleton;
 import org.apache.log4j.spi.LoggingEvent;
 import org.apache.samza.diagnostics.DiagnosticsExceptionEvent;
 import org.apache.samza.diagnostics.DiagnosticsManager;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 
 /**
@@ -35,7 +33,6 @@ import org.slf4j.LoggerFactory;
  * stream of diagnostics-related events.
  */
 public class SimpleDiagnosticsAppender extends AppenderSkeleton {
-  private static final Logger LOG = 
LoggerFactory.getLogger(SimpleDiagnosticsAppender.class);
 
   // simple object to synchronize root logger attachment
   private static final Object SYNCHRONIZATION_OBJECT = new Object();
@@ -57,7 +54,7 @@ public class SimpleDiagnosticsAppender extends 
AppenderSkeleton {
   private void attachAppenderToRootLogger() {
     // ensure appender is attached only once per JVM (regardless of 
#containers)
     if 
(org.apache.log4j.Logger.getRootLogger().getAppender(SimpleDiagnosticsAppender.class.getName())
 == null) {
-      LOG.info("Attaching diagnostics appender to root logger");
+      System.out.println("Attaching diagnostics appender to root logger");
       org.apache.log4j.Logger.getRootLogger().addAppender(this);
     }
   }
@@ -73,13 +70,10 @@ public class SimpleDiagnosticsAppender extends 
AppenderSkeleton {
                 loggingEvent.getProperties());
 
         diagnosticsManager.addExceptionEvent(diagnosticsExceptionEvent);
-        LOG.debug("Received DiagnosticsExceptionEvent " + 
diagnosticsExceptionEvent);
-      } else {
-        LOG.debug("Received non-exception event with message " + 
loggingEvent.getMessage());
       }
     } catch (Exception e) {
       // blanket catch of all exceptions so as to not impact any job
-      LOG.error("Exception in logging event parsing", e);
+      System.err.println("Exception in logging event parsing " + e);
     }
   }
 
diff --git 
a/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java
 
b/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java
index 932b3f7..fa65199 100644
--- 
a/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java
+++ 
b/samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/SimpleDiagnosticsAppender.java
@@ -28,8 +28,6 @@ import org.apache.logging.log4j.core.config.Configuration;
 import org.apache.logging.log4j.core.config.LoggerConfig;
 import org.apache.samza.diagnostics.DiagnosticsExceptionEvent;
 import org.apache.samza.diagnostics.DiagnosticsManager;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Provides an in-memory appender that parses LogEvents to filter events 
relevant to diagnostics.
@@ -39,7 +37,6 @@ import org.slf4j.LoggerFactory;
  * stream of diagnostics-related events.
  */
 public class SimpleDiagnosticsAppender extends AbstractAppender {
-  private static final Logger LOG = 
LoggerFactory.getLogger(SimpleDiagnosticsAppender.class);
 
   // simple object to synchronize root logger attachment
   private static final Object SYNCHRONIZATION_OBJECT = new Object();
@@ -62,7 +59,7 @@ public class SimpleDiagnosticsAppender extends 
AbstractAppender {
 
     // ensure appender is attached only once per JVM (regardless of 
#containers)
     if 
(config.getRootLogger().getAppenders().get(SimpleDiagnosticsAppender.class.getName())
 == null) {
-      LOG.info("Attaching diagnostics appender to root logger");
+      System.out.println("Attaching diagnostics appender to root logger");
       appender.start();
       config.addAppender(appender);
       for (final LoggerConfig loggerConfig : config.getLoggers().values()) {
@@ -81,13 +78,10 @@ public class SimpleDiagnosticsAppender extends 
AbstractAppender {
                 logEvent.getContextData().toMap());
 
         diagnosticsManager.addExceptionEvent(diagnosticsExceptionEvent);
-        LOG.debug("Received DiagnosticsExceptionEvent " + 
diagnosticsExceptionEvent);
-      } else {
-        LOG.debug("Received non-exception event with message " + 
logEvent.getMessage());
       }
     } catch (Exception e) {
       // blanket catch of all exceptions so as to not impact any job
-      LOG.error("Exception in logevent parsing", e);
+      System.err.println("Exception in logevent parsing " + e);
     }
   }
 }