prateekm commented on a change in pull request #1172: SAMZA-2332: [AM
isolation] YarnJob should pass new command and additional environment variables
for AM deployment
URL: https://github.com/apache/samza/pull/1172#discussion_r332279179
##########
File path:
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
##########
@@ -50,6 +50,17 @@ object ShellCommandConfig {
*/
val ENV_EXECUTION_ENV_CONTAINER_ID = "EXECUTION_ENV_CONTAINER_ID"
+ /**
+ * Set to "true" if application master isolation is enabled. Otherwise, will
be considered false.
+ */
+ val ENV_APPLICATION_MASTER_ISOLATION_ENABLED =
"APPLICATION_MASTER_ISOLATION_ENABLED"
+
+ /**
+ * Can be set to a directory which is different from the base lib directory
which contains some additional
+ * application-specific resources.
Review comment:
Can you clarify (in docs) what this env variable is used for? E.g., what's a
'base lib directory', when would you set it to a non-'base lib directory', and
what additional application-specific resources? Also, why would you do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
