xinyuiscool commented on issue #1190: SAMZA-2352: Use min.compaction.lag.ms to avoid compacting the Kafka changelog topic URL: https://github.com/apache/samza/pull/1190#issuecomment-542316524 @prateekm : the current logic already allows user to override the value for each store, using something like ""stores.test2.changelog.kafka.min.compaction.lag.ms". The unit test I added verified it. Currently all the other changelog related configs live in KafkaConfig, like replication factor and max message bytes. So the new config also went in there. KafkaConfig also takes care of the overrides too. Let me add a getter in KafkaConfig for getting this value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
