atoomula commented on a change in pull request #1192: SAMZA-2354: Improve UDF
discovery in samza-sql.
URL: https://github.com/apache/samza/pull/1192#discussion_r335271453
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/runner/SamzaSqlApplicationConfig.java
##########
@@ -214,7 +214,7 @@ private UdfResolver createUdfResolver(Map<String, String>
config) {
Properties props = new Properties();
props.putAll(domainConfig);
HashMap<String, String> udfConfig = getDomainProperties(config,
CFG_UDF_CONFIG_DOMAIN, false);
- return new ConfigBasedUdfResolver(props, new MapConfig(udfConfig));
+ return new ReflectionBasedUdfResolver(new MapConfig(udfConfig));
Review comment:
Sorry, I didn't realize that this is hard-coded here. Could we make this
pluggable ? I think calling initializePlugin like above should do it with the
udf resolver based arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
