Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r348793319
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
##########
@@ -109,17 +144,26 @@ void handleContainerStop(String processorId, String
containerId, String preferre
/**
* Handle the container launch failure for active containers and standby (if
enabled).
- * Case 1. When standby is enabled, refer to {@link
StandbyContainerManager#handleContainerLaunchFail} to check behavior
- * Case 2. When standby is disabled the allocator issues a request for
ANY_HOST resources
*
- * @param processorId logical id of the container
+ * Case 1. If this launch was issued due to an existing container placement
action update the metadata to report failure and issue
+ * a request for source host where the container was last seen and
mark the container placement failed
+ * Case 2. When standby is enabled, refer to {@link
StandbyContainerManager#handleContainerLaunchFail} to check behavior
+ * Case 3. When standby is disabled the allocator issues a request for
ANY_HOST resources
+ *
+ * @param processorId logical id of the container eg 1,2,3
* @param containerId last known id of the container deployed
* @param preferredHost host on which container is requested to be deployed
* @param containerAllocator allocator for requesting resources
*/
void handleContainerLaunchFail(String processorId, String containerId,
String preferredHost,
ContainerAllocator containerAllocator) {
- if (processorId != null && standbyContainerManager.isPresent()) {
+ if (processorId != null &&
getControlActionMetadata(processorId).isPresent()) {
+ ContainerPlacementMetadata metaData =
getControlActionMetadata(processorId).get();
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
